Sort Images Correctly™ (by blus007)#21
Draft
halotroop2288 wants to merge 5 commits intoNeeEoo:masterfrom
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't know what I'm doing here. I just want to fix the sorting issue. I saw this solution in another fork, so I rebased it on Funkin-Packer because it's a lot more up-to-date.
This doesn't actually appear to work though. It's still inserting images with a higher-digit index into the middle of the list. Which makes this useless for programmatic animation.
I don't have experience with JavaScript or sorting algorithms so this is nonsense to me. If you can figure out why it's not working, please tell me and I'll try it out.